Integrate Probabilit - #749
Merged
Merged
Conversation
tommyod
force-pushed
the
probabilit
branch
2 times, most recently
from
October 8, 2025 09:57
30f1aa3 to
593f747
Compare
tommyod
marked this pull request as ready for review
October 8, 2025 10:04
dafeda
reviewed
Oct 8, 2025
dafeda
reviewed
Oct 8, 2025
dafeda
reviewed
Oct 8, 2025
| if correlation_iterations > 0: | ||
| correlator = probabilit.correlation.Composite( | ||
| iterations=correlation_iterations, | ||
| correlation_type="pearson", |
Contributor
There was a problem hiding this comment.
Should users be able to set the correlation type?
Contributor
Author
There was a problem hiding this comment.
I think most users care about pearson. But i will add a little comment in the code. Perhaps we should ask users if this is of interest. Personally I think it might not be that important to them, but who knows!
Contributor
There was a problem hiding this comment.
Not sure about this as Iman-Conover uses spearman. Let's have a chat.
dafeda
reviewed
Oct 8, 2025
dafeda
reviewed
Oct 8, 2025
tommyod
force-pushed
the
probabilit
branch
2 times, most recently
from
October 9, 2025 14:19
87ce82b to
45503aa
Compare
- Use probabilit for random variable generation - Add option 'correlation_iterations' in general input sheet (default=0 => ImanConover) - Since variable sampling is not done in the same order, RNG is different and snapshot had to be used - Slight discrepancies in Mac and Linux RNG. Fixed by letting snapshot compare 6 siginificant digits - Added a test file with 6 lognorms, that showcases how we get better correlation matrices if correlation_iterations > 0 - Deleted ImanConover, nearest_correlation_matrix, etc. These are all in probabilit
dafeda
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes around 400 lines of code in total. Removes all LHS, ImanConover, etc responsibility from fmudesign - focusing it back on being a CLI tool that "glues" functionality together instead of implmeneting scientific routines. Improve correlation matrices (defaults to ImanConover though)